Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Attributes to LegBoard, LegAligt und LegIntermediate #406

Merged
merged 20 commits into from
Oct 16, 2023
Merged

Added Attributes to LegBoard, LegAligt und LegIntermediate #406

merged 20 commits into from
Oct 16, 2023

Conversation

ue71603
Copy link
Contributor

@ue71603 ue71603 commented Sep 26, 2023

and improved example to show it.

We have on LegStart and LegEnd attributes we currently don't have them on LegBoard, LegAlight and LegIntermediate

@ue71603 ue71603 added enhancement New feature or request documentation labels Sep 26, 2023
@ue71603 ue71603 added this to the v2.0 milestone Sep 26, 2023
skinkie
skinkie reviewed Sep 27, 2023
View reviewed changes
OJP/OJP_JourneySupport.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Sep 27, 2023
View reviewed changes
OJP/OJP_Trips.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Sep 27, 2023
View reviewed changes
OJP/OJP_Trips.xsd Outdated Show resolved Hide resolved
skinkie
skinkie reviewed Sep 27, 2023
View reviewed changes
OJP/OJP_Trips.xsd Outdated Show resolved Hide resolved
skinkie
skinkie previously approved these changes Sep 27, 2023
View reviewed changes
trurlurl
trurlurl previously approved these changes Sep 27, 2023
View reviewed changes
@ue71603
Copy link
Contributor Author

ue71603 commented Oct 3, 2023

@herlitze @normanoffel without comment from you until tomorrow, @skinkie will merge it tomorrow.

@herlitze
Copy link
Contributor

herlitze commented Oct 4, 2023

Do I see it correctly that the attributes always occur in parallel with a StopCallStatusGroup and there is no use of a StopCallStatusGroup that should not be extended? If yes, what speaks against extending the StopCallStatusGroup with the attributes?

@ue71603
Copy link
Contributor Author

ue71603 commented Oct 4, 2023

Do I see it correctly that the attributes always occur in parallel with a StopCallStatusGroup and there is no use of a StopCallStatusGroup that should not be extended? If yes, what speaks against extending the StopCallStatusGroup with the attributes?

@herlitze Shold I put the Attribute into the CallStatusGroup? Can do that

@herlitze
Copy link
Contributor

herlitze commented Oct 4, 2023

Do I see it correctly that the attributes always occur in parallel with a StopCallStatusGroup and there is no use of a StopCallStatusGroup that should not be extended? If yes, what speaks against extending the StopCallStatusGroup with the attributes?

@herlitze Shold I put the Attribute into the CallStatusGroup? Can do that

Yes, I see no reason against it.

@ue71603 ue71603 dismissed stale reviews from trurlurl and skinkie via 0d1233a October 4, 2023 09:23
@ue71603
Copy link
Contributor Author

ue71603 commented Oct 4, 2023

Do I see it correctly that the attributes always occur in parallel with a StopCallStatusGroup and there is no use of a StopCallStatusGroup that should not be extended? If yes, what speaks against extending the StopCallStatusGroup with the attributes?

@herlitze Shold I put the Attribute into the CallStatusGroup? Can do that

Yes, I see no reason against it.

changed

herlitze
herlitze previously approved these changes Oct 4, 2023
View reviewed changes
@ue71603 ue71603 mentioned this pull request Oct 4, 2023
Merged
trurlurl
trurlurl previously approved these changes Oct 4, 2023
View reviewed changes
skinkie
skinkie reviewed Oct 11, 2023
View reviewed changes
examples/functions/location/LIR_01_response_simple_StopPoint.xml Outdated
@@ -38,6 +38,21 @@
<PtMode>bus</PtMode>
<siri:BusSubmode>localBusService</siri:BusSubmode>
</Mode>
<Attribute>
<Text>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This double is correct?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is correct. but I changed it now with the latest commit

trurlurl
trurlurl previously approved these changes Oct 15, 2023
View reviewed changes
github-actions bot and others added 16 commits October 16, 2023 12:06
@github-actions @ue71603
Lint and update documentation tables
18bf1a3
@github-actions @ue71603
Lint and update documentation tables
cd8fd22
@ue71603 @skinkie
Update OJP/OJP_Trips.xsd
dc5db97 
Co-authored-by: Stefan de Konink <[email protected]>
@ue71603 @skinkie
Update OJP/OJP_Trips.xsd
0f225d1 
Co-authored-by: Stefan de Konink <[email protected]>
@ue71603 @skinkie
Update OJP/OJP_JourneySupport.xsd
942f53c 
Co-authored-by: Stefan de Konink <[email protected]>
@ue71603 @skinkie
Update OJP/OJP_Trips.xsd
2cef77b 
Co-authored-by: Stefan de Konink <[email protected]>
@github-actions @ue71603
Lint and update documentation tables
26338c0
@ue71603
Attribute now part of StopCallStatusGroup
b554315
@github-actions @ue71603
Lint and update documentation tables
de7d1e9
@ue71603
Integrated ParkingFacility, had to rebuild it from siri:AllFAcilityFe…
f368538 
…atureStructure

must be corrected in SIRI as well
@ue71603
fixing examples
70db926
@github-actions @ue71603
Lint and update documentation tables
81213b4
@ue71603
Key/Value added to Attribute
6c3354b
@github-actions @ue71603
Lint and update documentation tables
ac1371c
@ue71603
<Text><Text> changed in Attribute
83c9f91
@github-actions @ue71603
Lint and update documentation tables
d5d29eb
@ue71603 ue71603 force-pushed the Accessibility-on-LegParts branch from 9acaff5 to d5d29eb Compare October 16, 2023 10:11
skinkie
skinkie previously approved these changes Oct 16, 2023
View reviewed changes
Copy link
Contributor

@skinkie skinkie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, suggestion IDC.

trurlurl
trurlurl reviewed Oct 16, 2023
View reviewed changes
OJP/OJP_Common.xsd
@@ -449,7 +449,21 @@
<xs:documentation>Internal code of the attribute. Can be used for detection of double occurrences.</xs:documentation>
</xs:annotation>
</xs:element>
<xs:group ref="AllFacilitiesGroup"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the AllFacilitiesGroup isn't used anywhere any more, could be removed...?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@ue71603
removing AllFacilitiesGroup
724c5e5 
we always refer the siri: if necesasry
@skinkie skinkie merged commit c58e03d into changes_for_v1.1 Oct 16, 2023
@skinkie skinkie deleted the Accessibility-on-LegParts branch October 16, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trurlurl trurlurl trurlurl approved these changes

@skinkie skinkie skinkie approved these changes

@herlitze herlitze herlitze left review comments

@Aurige Aurige Awaiting requested review from Aurige

Assignees
No one assigned
Labels
doc updated enhancement New feature or request
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ue71603 @herlitze @skinkie @trurlurl