fix: add tooltip to make users aware of disabled favorited content #580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtucholski
requested changes
Dec 11, 2024
There was a problem hiding this comment.
@CK-7vn Tooltip looks good. Can you bump the top margin for Operational Insights? Horizontally it looks good, but it looks like it's a bit closer to the top than the other headings.
|
@jtucholski Added the top-margin, should be good now |
PThorpe92
approved these changes
Dec 12, 2024
PThorpe92
force-pushed
the
unavailable_tooltip
branch
from
81c8e72 to
46e976c
Compare
PThorpe92
force-pushed
the
unavailable_tooltip
branch
from
46e976c to
1180004
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This adds a tooltip "Unavailable Content" to any favorited content that has been disabled by an Admin since being favorited. Also fixes an admin check on the Library Card that was causing the favoriting star not to be rendered for students. Also adds appropriate spacing in Operational Insights
Screenshot(s)