Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add Puppeteer student discussion posts to Canvas #254

Merged
merged 4 commits into from
Jun 4, 2024

Conversation

coledykstra
Copy link
Contributor

No description provided.

canvas-discussion-bot/index.js Outdated Show resolved Hide resolved
canvas-discussion-bot/index.js Outdated Show resolved Hide resolved
@@ -0,0 +1,3 @@
API_TOKEN=my_api_token
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you move this into the canvas-seeder directory so they can share the same .env file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't they be independent?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's still a canvas seeder, we don't want to pollute the top level directory, plus it's the same exact .env file.

Copy link
Contributor Author

@coledykstra coledykstra Jun 1, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I just assume the other project is there? How do I change index.js to get that to work. Do I need something like

// Specify the path to the .env file for the local directory
const envFilePath = path.resolve(__dirname, '.env');

// Load the .env file
const result = dotenv.config({ path: envFilePath });

Which I already don't like doing. Can I just merge both .env into the top level one?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can just put all the files into the existing canvas-seederdirectory

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought you were saying to just move the single line
API_TOKEN=my_api_token
I can put the whole node.js project into the same folder as the Go project?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah definitely, just put it all in the 'canvas-seeder' directory

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and the other directory can be removed now that it's merged into canvas-seeder

@PThorpe92 PThorpe92 merged commit 86dae87 into UnlockedLabs:main Jun 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants