Add ungreedy alternative to replace
#45
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
commented
Dec 15, 2021
| , testGroup "replaceAll" | ||
| [ u "t1" | ||
| (replaceAll ("x" <$ "a" <|> "y" <$ "ab") "tabc") | ||
| "txbc" |
There was a problem hiding this comment.
There is indeed a behavioural difference. This one is ungreedy also in alternative, which is probably not what we want either. Maybe the issue is actually that findLongestInfix does not respect few.
|
Thanks Jan. I already merged your doctest commit. As for the replace function, someone will have to dig into it and figure out what exactly is going on there and whether it needs fixing. Unfortunately, I don't know if I'll have for this in the nearest future. But if this fix works for you, you can just include this modified function in your own project. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #44
While at it, also add doctests.