Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organisation survey course add expanded #1422

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Organisation survey course add expanded #1422

wants to merge 10 commits into from

Conversation

tfhuhtal
Copy link
Contributor

This pull request includes several changes to enhance the functionality and user experience of the organisation survey feature. The updates include modifications to the translation files, improvements to the frontend components, and significant backend changes for handling courses associated with surveys.

Translation Updates:

  • Added the "removeCourse" translation to public/locales/en/translation.json, public/locales/fi/translation.json, and public/locales/sv/translation.json. [1] [2] [3]

Frontend Enhancements:

  • Updated EditOrganisationSurvey.jsx to include courses in the survey data and corrected the mapping of course IDs. [1] [2]
  • Enhanced CourseSearchInput.tsx by adding a confirmation dialog when removing courses, using Chip for selected courses, and ensuring proper state management for date range options. [1] [2] [3] [4] [5]
  • Removed unnecessary Chip component from OrganisationSurveyEditor.jsx.

Backend Enhancements:

  • Created a new migration to add the organisation_survey_courses table.
  • Updated organisationSurveyController.js to handle the creation and editing of organisation survey courses. [1] [2]
  • Added new methods in organisationSurveys.js for managing organisation survey courses and retrieving course students. [1] [2] [3] [4] [5]

This is related to issues #1357 , #1408 and to feature-draft documentation/feature_drafts/20241217_00_opiskelijoiden_tuonti_kursseilta_organisaatiokyselyyn.md

@tfhuhtal tfhuhtal requested a review from HRemonen December 17, 2024 14:09
Copy link
Contributor

@HRemonen HRemonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty solid, a bit concerned about the performance but I think time will tell and then if performance seems to be a problem it can be debugged separately!

Good job.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not regarding this PR necessarily, but I will put it here while I remember:
Let's extract the types from this CourseSearchInput to src/client/types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants