-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organisation survey course add expanded #1422
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty solid, a bit concerned about the performance but I think time will tell and then if performance seems to be a problem it can be debugged separately!
Good job.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not regarding this PR necessarily, but I will put it here while I remember:
Let's extract the types from this CourseSearchInput
to src/client/types
This pull request includes several changes to enhance the functionality and user experience of the organisation survey feature. The updates include modifications to the translation files, improvements to the frontend components, and significant backend changes for handling courses associated with surveys.
Translation Updates:
public/locales/en/translation.json
,public/locales/fi/translation.json
, andpublic/locales/sv/translation.json
. [1] [2] [3]Frontend Enhancements:
EditOrganisationSurvey.jsx
to include courses in the survey data and corrected the mapping of course IDs. [1] [2]CourseSearchInput.tsx
by adding a confirmation dialog when removing courses, usingChip
for selected courses, and ensuring proper state management for date range options. [1] [2] [3] [4] [5]Chip
component fromOrganisationSurveyEditor.jsx
.Backend Enhancements:
organisation_survey_courses
table.organisationSurveyController.js
to handle the creation and editing of organisation survey courses. [1] [2]organisationSurveys.js
for managing organisation survey courses and retrieving course students. [1] [2] [3] [4] [5]This is related to issues #1357 , #1408 and to feature-draft
documentation/feature_drafts/20241217_00_opiskelijoiden_tuonti_kursseilta_organisaatiokyselyyn.md