New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused "deadline" parameter #818

Open

Skitzzy wants to merge 1 commit into Uniswap:main from Skitzzy:fix_v3_router_swap_documentation

Skitzzy commented Nov 21, 2024

The "deadline" parameter present in documentation for v3 single swaps is not part of the actual contract interface for the v3 swap router:

Example: https://basescan.org/address/0x2626664c2603336E57B271c5C0b26F421741e481#writeProxyContract#F7


          remove unused "deadline" parameter

673695d

vercel bot commented Nov 21, 2024

@Skitzzy is attempting to deploy a commit to the Uniswap Team on Vercel.

A member of the Team first needs to authorize it.

Contributor

seeyijie commented Dec 3, 2024

SwapRouter02 contract refers to https://github.com/Uniswap/swap-router-contracts/blob/main/contracts/interfaces/IV3SwapRouter.sol and not this repository

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet