added some changes in Jenkinsfile #173
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tushar5526
reviewed
May 4, 2023
build/Jenkinsfile
Outdated
| sh ''' | ||
| docker build -t $docker_server/$docker_repo:latest . | ||
| ''' | ||
| } else if (env.BRANCH_NAME == 'main' || env.BRANCH_NAME == 'staging'){ |
There was a problem hiding this comment.
What is the logic here, and why for both main and staging? we are building latest tagged repo ?
There was a problem hiding this comment.
it is written
if any changes happens at main branch then it will pickup the command mentioned in that and if any changes push on staging then it will take that changes
and also in last stage it will deploy it according to changes pushed to respective
branch
There was a problem hiding this comment.
For main, it will never go to the second if. Please walk through the if else logic once. Also verify the tags again.
There was a problem hiding this comment.
yes
but if it is for staging then ?
then it will go for 2nd na
?
tushar5526
reviewed
May 8, 2023
|
LGTM |
|
Please fix the merge conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.