Add basic filters to search view #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tijmen Baarda <[email protected]>
Signed-off-by: Tijmen Baarda <[email protected]>
Signed-off-by: Tijmen Baarda <[email protected]>
Signed-off-by: Tijmen Baarda <[email protected]>
jgonggrijp
approved these changes
Oct 9, 2024
There was a problem hiding this comment.
I scrolled through the code and tried the tables that resulted from searches in the KB and the HPB. It seems to work well.
Small comment: the title filter input is larger than the filter inputs of the other columns. This makes intuitive sense, but it looks a little bit disorganized, also because the border of the input (textarea?) looks slightly different. I suggest making this input of the same type as the other columns, but this is not a requirement for approval.
Larger comment: pattern searching would be convenient, perhaps regex-based. That could certainly wait, though.
Overall, I like it a lot!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.