Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(EMS-4024): declarations - modern slavery - form validation #3410

Merged
merged 10 commits into from
Dec 17, 2024
Merged

feat(EMS-4024): declarations - modern slavery - form validation #3410

merged 10 commits into from
Dec 17, 2024

Conversation

ttbarnes
Copy link
Contributor

@ttbarnes ttbarnes commented Dec 14, 2024 •
edited
Loading

Introduction ✏️

This PR adds form validation to the "declarations - modern slavery" form.

Resolution ✔️

  • Create new cypress commands:
    • cy.completeAndSubmitModernSlaveryForm
    • cy.completeModernSlaveryFormConditionalFields
    • cy.completeModernSlaveryForm
  • Update error messages content strings.
  • Add E2E tests.
  • Update UI controller FIELD_IDS.
  • Create new POST route/controller.
  • Create new UI validation rules.
  • Update nunjucks partials.

Miscellaneous ➕

  • Minor cypress command improvements.
  • Update cy.submitAndAssertRadioErrors to call cy.assertFieldErrors to be DRY.

@ttbarnes ttbarnes added documentation Improvements or additions to documentation enhancement New feature or request feature New functionality tech Technical debt/improvements chore Chore labels Dec 14, 2024
@ttbarnes ttbarnes self-assigned this Dec 14, 2024
Zainzzkk
Zainzzkk previously approved these changes Dec 17, 2024
View reviewed changes
Base automatically changed from feat/EMS-4038 to main-declarations-modern-slavery December 17, 2024 13:11
@ttbarnes ttbarnes dismissed Zainzzkk’s stale review December 17, 2024 13:11

The base branch was changed.

@ttbarnes ttbarnes merged commit 7fdb15c into main-declarations-modern-slavery Dec 17, 2024
183 of 184 checks passed
@ttbarnes ttbarnes deleted the feat/EMS-4024 branch December 17, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zainzzkk Zainzzkk Zainzzkk approved these changes

Assignees

@ttbarnes ttbarnes

Labels
chore Chore documentation Improvements or additions to documentation enhancement New feature or request feature New functionality tech Technical debt/improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttbarnes @Zainzzkk