-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce phpstan #5
base: feat/source-wordpress-v4
Are you sure you want to change the base?
Introduce phpstan #5
Conversation
Please see individual commits. |
@@ -297,7 +297,7 @@ function updateUserIsPublic( $post_id, $post ) { | |||
? $current_user->data->user_nicename | |||
: "User"; | |||
|
|||
$relay_id = Relay::toGlobalId( 'user', $user_id ); | |||
$relay_id = Relay::toGlobalId( 'user', strval( $user_id ) ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TylerBarnes ID should be a string as it goes into base64_encode
See https://github.com/ivome/graphql-relay-php/blob/master/src/Relay.php#L188
Thanks for this @szepeviktor ! |
All right. |
@jasonbahl Friendly ping 🏓 |
Hey, I don't maintain this plugin anymore. I think it makes a lot of sense to add phpstan though! Use it on all my plugins now |
@TylerBarnes What do you suggest? |
@TylerBarnes Is this PR okay?
Should I send it to your repo?