-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft DA script #57
base: main
Are you sure you want to change the base?
Draft DA script #57
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…SMProblems.jl into ck/particle-methods
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely stellar demonstration, data assimilation is such a good example. Also those 3D plots are so cool
SSMProblems = "26aad666-b158-4e64-9d35-0e672562fa48" | ||
StaticArrays = "90137ffa-7385-5640-81b9-e52037218182" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sure this is just left over from some experimentation. Did you try running anything with StaticArrays
?
end | ||
|
||
function SSMProblems.distribution(obs::ObservationNoiseProcess, step::Integer, state, extra) | ||
return MvNormal(state, obs.σ * I) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the importance of having the identity matrix in obs.σ * I
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's redundant, obs.σ
is already a PDMat. Didn't catch that
lineage = get_ancestry(sparse_ancestry.tree) | ||
|
||
# Fancy 3D plot | ||
# fig = Figure() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm obsessed with this plot
No description provided.