Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated Formatting #451

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Remove deprecated Formatting #451

merged 2 commits into from
Feb 28, 2024

Conversation

devmotion
Copy link
Member

@devmotion devmotion commented Feb 28, 2024

It's not clear to me where/if Formatting is used at all in MCMCChains.

Fixes #450.

Edit: Test errors are unrelated and should be fixed by #452.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.70%. Comparing base (52cc3e2) to head (3134cea).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #451   +/-   ##
=======================================
  Coverage   84.70%   84.70%           
=======================================
  Files          20       20           
  Lines        1072     1072           
=======================================
  Hits          908      908           
  Misses        164      164           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@devmotion devmotion marked this pull request as ready for review February 28, 2024 14:01
@devmotion devmotion requested review from yebai and torfjelde February 28, 2024 14:02
@devmotion devmotion merged commit 5f8e591 into master Feb 28, 2024
10 checks passed
@devmotion devmotion deleted the dw/formatting branch February 28, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formatting.jl is deprecated
2 participants