CompatHelper: bump compat for MLJBase to 1 for package test, (keep existing compat) #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
devmotion
force-pushed
the
compathelper/new_version/2023-09-26-00-11-56-608-01377236588
branch
from
c12d1b0 to
70d13db
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #435 +/- ##
=======================================
Coverage 84.62% 84.62%
=======================================
Files 20 20
Lines 1067 1067
=======================================
Hits 903 903
Misses 164 164 ☔ View full report in Codecov by Sentry. |
yebai
changed the base branch from
master
to
compathelper/new_version/2023-09-26-00-11-12-754-03791291870
yebai
merged commit ba55f6d
into
compathelper/new_version/2023-09-26-00-11-12-754-03791291870
8 of 9 checks passed
yebai
deleted the
compathelper/new_version/2023-09-26-00-11-56-608-01377236588
branch
yebai
pushed a commit
that referenced
this pull request
Oct 26, 2023
…isting compat) (#434) * CompatHelper: bump compat for MLJBase to 1 for package docs, (keep existing compat) * CompatHelper: bump compat for MLJBase to 1 for package test, (keep existing compat) (#435) Co-authored-by: CompatHelper Julia <[email protected]> --------- Co-authored-by: CompatHelper Julia <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
MLJBasepackage from0.18, 0.19, 0.20, 0.21to0.18, 0.19, 0.20, 0.21, 1for package test.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.