Make CI + tests more efficient #749
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
penelopeysm
force-pushed
the
py/separate-doctests
branch
from
e86d99f to
eafd2b5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #749 +/- ##
==========================================
- Coverage 86.02% 85.94% -0.09%
==========================================
Files 36 36
Lines 4272 4276 +4
==========================================
Hits 3675 3675
- Misses 597 601 +4 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12302264036Details
💛 - Coveralls |
Pull Request Test Coverage Report for Build 12315584178Details
💛 - Coveralls |
penelopeysm
force-pushed
the
py/separate-doctests
branch
3 times, most recently
from
9b05e78 to
3042394
Compare
penelopeysm
changed the title
penelopeysm
force-pushed
the
py/separate-doctests
branch
from
3042394 to
4c18b03
Compare
|
I think this PR should be reviewable! Coverage is the other thing that frankly annoys me. I don't see how my changes could have led to any decrease in coverage. That said, at least it's not part of the 'required checks', so it wouldn't mess with the merge queue. Note: The 'required checks' below refer to the CI jobs that existed prior to this PR, i.e. the tests that weren't split up. The 'expected check' is just GitHub waiting for a job with that name to be run. If this PR is merged, those required checks will have to be edited in the repo settings. |
penelopeysm
force-pushed
the
py/separate-doctests
branch
from
4c18b03 to
60f4d33
Compare
penelopeysm
force-pushed
the
py/separate-doctests
branch
from
60f4d33 to
5174143
Compare
mhauru
requested changes
Dec 13, 2024
|
Branch protection rules updated too so that should show up right on the next PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does a bunch of individually minor things, detailed below, but the broad effect is:
The time taken to run DynamicPPL CI should be cut down to ca. 30 minutes. It was close to 2 hours previously.
We should get back the green tick so that we can stop force-merging everything.
Fixes x86 2threads ubuntu CI OOM failure #725
CI
Separates the tests into two different groups. This was meant as a solution to x86 2threads ubuntu CI OOM failure #725, because the OOM error doesn't happen if you only run the doctests and not the main test suite before it.
Disables fail-fast on the CI matrix, as we don't want half the tests to fail if there's an error in the other half.
Enables concurrency on the CI job so that pushing a new commit to the same PR cancels CI running on previous commits
Tests themselves
Suppresses unnecessary output in the test suite (sampling progress, also the result of
model_warntype)Add
verbose = trueto the top-level@testsetso that a breakdown of timings / number of tests is printed at the endRemoves one layer of an unneeded double loop over the demo models in
test/sampler.jl, which cuts approximately 45 mins from CI.