Try just 1 thread on x86 #747
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #747 +/- ##
=======================================
Coverage 86.49% 86.49%
=======================================
Files 36 36
Lines 4272 4272
=======================================
Hits 3695 3695
Misses 577 577 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12299146619Details
💛 - Coveralls |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -42,7 +42,7 @@ Random.seed!(100) | |||
|
|
|||
| include("test_util.jl") | |||
|
|
|||
| @testset "DynamicPPL.jl" begin | |||
| @testset verbose=true "DynamicPPL.jl" begin | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| @testset verbose=true "DynamicPPL.jl" begin | |
| @testset verbose = true "DynamicPPL.jl" begin |
penelopeysm
force-pushed
the
py/gcthreads
branch
from
9c986fc to
03935b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt at fixing #725.Doesn't work. At this point I'm pretty sure there's an issue with the Julia GC when it runs on x86.