Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix OneHotEncoder usage in sklearn example notebook #541

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix OneHotEncoder usage in sklearn example notebook #541

wants to merge 1 commit into from

Conversation

codell2
Copy link

@codell2 codell2 commented Dec 3, 2024

Updated the OneHotEncoder usage in examples/sklearn/demo_new_features.ipynb to replace the deprecated sparse parameter with sparse_output. This resolves an error on Issue #529 during compilation due to recent updates in sklearn's API.

@codell2 codell2 force-pushed the fix-onehotencoder-issue branch from 73876c0 to f5a019c Compare December 3, 2024 03:59
@codell2
Copy link
Author

codell2 commented Dec 6, 2024

The test suite is failing due to an issue in tests/sklearn/test_datasets.py involving the use of np.NaN, which was removed in NumPy 2.0. This issue is unrelated to my change, which only updates demo_new_features.ipynb. The issue can be fixed by changing this to np.nan.

@hoffmansc hoffmansc closed this Dec 10, 2024
@hoffmansc hoffmansc reopened this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codell2 @hoffmansc