micronaut framework implemented. #673
Conversation
There was a problem hiding this comment.
Thanks for the PR!
This PR does not build and compile. Could you please apply the changes, and the open the project from settings.gradle.kts level. I observe gradle-wrapper additions which should not be case for any change.
Also instead of micronaut-starter, lets keep micronaut as the name for the folder.
| id("stove-publishing") apply false | ||
| idea | ||
| java | ||
| } | ||
| group = "com.trendyol" | ||
| version = CI.version(project) | ||
| version = version() |
There was a problem hiding this comment.
I wouldn't expect any change for this line.
| dependencies { | ||
| related.forEach { | ||
| kover(it) | ||
| } | ||
| } | ||
|
|
||
| subprojects.of("lib", "spring", "examples", "ktor") { | ||
| subprojects.of("lib", "spring", "examples", "ktor", "micronaut-starter") { |
There was a problem hiding this comment.
micronaut is better naming instead of starter.
There was a problem hiding this comment.
There shouldn't be any gradle-wrapper extra. Why this build system added?
| } | ||
|
|
||
| dependencies { | ||
| runtimeOnly("org.yaml:snakeyaml:2.1") |
There was a problem hiding this comment.
We don't add hardcoded versions, they need to be moved into libs.versions.toml.
| id("io.micronaut.aot") version "4.4.3" | ||
| } | ||
|
|
||
| repositories { |
There was a problem hiding this comment.
there should not be repository definition here.
| kotlin("plugin.serialization") version libs.versions.kotlin | ||
| application | ||
| idea | ||
| id("com.google.devtools.ksp") version "1.9.25-1.0.20" |
There was a problem hiding this comment.
This is also a mistake probably.
There was a problem hiding this comment.
Please remove .idea folders.
| @@ -42,21 +40,41 @@ kover { | |||
| } | |||
| } | |||
| } | |||
| val related = subprojects.of("lib", "spring", "examples", "ktor") | |||
| val related = subprojects.of("lib", "spring", "examples", "ktor", "micronaut-starter") | |||
| plugin(rootProject.libs.plugins.testLogger.get().pluginId) | ||
| plugin(rootProject.libs.plugins.kover.get().pluginId) | ||
| plugin(rootProject.libs.plugins.detekt.get().pluginId) | ||
| plugin( |
There was a problem hiding this comment.
Could you revert the alignment back.
| ) | ||
|
|
||
| subprojects.of("lib", "spring", "ktor", filter = { p -> publishedProjects.contains(p.name) }) { | ||
| subprojects.of("lib", "spring", "ktor", "micronaut-starter", filter = { p -> publishedProjects.contains(p.name) }) { |
| @@ -160,3 +178,11 @@ tasks.withType<DokkaMultiModuleTask>().configureEach { | |||
| outputDirectory.set(file(rootDir.resolve("docs/source"))) | |||
| } | |||
|
|
|||
| fun version(): String = when { | |||
There was a problem hiding this comment.
This was deleted. It shouldn't be here.
| @@ -0,0 +1,13 @@ | |||
| dependencies { | |||
| api(projects.lib.stoveTestingE2e) | |||
| implementation("io.micronaut:micronaut-core") // Temel Micronaut bağımlılığı | |||
There was a problem hiding this comment.
- Remove comment
- Do not use hardcoded versions
| testImplementation("io.kotest:kotest-runner-junit5:5.7.2") | ||
| } | ||
|
|
||
| repositories { |
| @JvmStatic fun main(args: Array<String>) { | ||
| Micronaut.build() | ||
| .args(*args) | ||
| .packages("your.base.package.here") |
There was a problem hiding this comment.
why do we have hardcoded package name?
| } | ||
|
|
||
| override suspend fun afterProject() { | ||
| // Uygulama durdurma işlemi yapılabilir |
micronaut example created
micronaut starter created