Skip to content

Commit

Permalink
fix: readme and lint
Browse files Browse the repository at this point in the history
  • Loading branch information
ademekici committed Dec 16, 2024
1 parent f3ccc8c commit 4915946
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
10 changes: 5 additions & 5 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -133,19 +133,19 @@ Check out on [go-dcp](https://github.com/Trendyol/go-dcp#configuration)

## Exposed metrics

| Metric Name | Description | Labels | Value Type |
| Metric Name | Description | Labels | Value Type |
|-------------------------------------------------------|----------------------------------------|--------|------------|
| cbgo_kafka_connector_latency_ms_current | Time to adding to the batch. | N/A | Gauge |
| cbgo_kafka_connector_latency_ms_current | Time to adding to the batch. | N/A | Gauge |
| cbgo_kafka_connector_batch_produce_latency_ms_current | Time to produce messages in the batch. | N/A | Gauge |

You can also use all DCP-related metrics explained [here](https://github.com/Trendyol/go-dcp#exposed-metrics).
All DCP-related metrics are automatically injected. It means you don't need to do anything.

## Breaking Changes

| Date taking effect | Date announced | Change | How to check |
|--------------------|-------------------|--------------------------------|-----------------|
| November 11, 2023 | November 11, 2023 | Creating connector via builder | Compile project |
| Date taking effect | Date announced | Change | How to check |
|--------------------| ---- |---- |-----------------|
| November 11, 2023 | November 11, 2023 | Creating connector via builder | Compile project |

## Grafana Metric Dashboard

Expand Down
2 changes: 1 addition & 1 deletion kafka/rejection_log_sink_response_handler.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package kafka
import (
"context"
"fmt"

"github.com/Trendyol/go-dcp-kafka/config"
"github.com/Trendyol/go-dcp-kafka/kafka/message"
"github.com/Trendyol/go-dcp/logger"
Expand All @@ -24,7 +25,6 @@ func (r *RejectionLogSinkResponseHandler) OnInit(ctx *SinkResponseHandlerInitCon
r.Topic = ctx.Config.RejectionLog.Topic

err := r.KafkaClient.CheckTopics([]string{r.Topic})

if err != nil {
logger.Log.Error("error while rejection topic exist request, err: %v", err)
panic(err)
Expand Down

0 comments on commit 4915946

Please sign in to comment.