-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pause and unpause functions to TREX Gateway #189
Open
aliarbak
wants to merge
7
commits into
develop
Choose a base branch
from
trex-gateway-pausable
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify IA storage slot on proxies
aliarbak
commented
Feb 13, 2024
@@ -102,6 +102,12 @@ interface ITREXGateway { | |||
/// event emitted whenever a TREX token has been deployed by the TREX factory through the use of the Gateway | |||
event GatewaySuiteDeploymentProcessed(address indexed requester, address intendedOwner, uint256 feeApplied); | |||
|
|||
/// event emitted whenever the gateway is paused by an admin | |||
event GatewayPaused(address _userAddress); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't use the names "Paused" and "Unpaused" because they are used by the token contract. Otherwise, sharing the same event names as token events would cause ambiguity and collision on the indexer side.
Joachim-Lebrun
force-pushed
the
develop
branch
from
February 22, 2024 07:31
38ed737
to
0fa344b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pause
: Pauses the TREX gateway contract. When paused, no one can deploy a new token.unpause
: Unpauses the TREX gateway contract.