Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(TFM) Add transfer fees module #168

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Conversation

aliarbak
Copy link
Contributor

@aliarbak aliarbak commented Sep 20, 2023

Notes:

  • The minimum fee rate is 0.01% but must be given in uint format. So, when defining fee rates:
    • 1 = 0.01%
    • 10 = 0.1%
    • 100 = 1%
    • 1000 = 10%
    • 10000 = 100%
    • It can also be 0, which means no fee will be charged
  • canComplianceBind function is for the plug-and-play support discussed before. It checks whether the module is a token agent (and is required for the module to function). It should be called from the addComplianceModule
    • This is a draft function, I can update it after we decide how to proceed with the plug-and-play support.

@Joachim-Lebrun
Copy link
Collaborator

let's merge #169 first on develop and then you can add the plug&play functions on this module, then after making the small modifs i noted, we can merge this PR

Copy link
Collaborator

@Joachim-Lebrun Joachim-Lebrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Joachim-Lebrun
Copy link
Collaborator

just need to still add the isPlugAndPlay and canComplianceBind functions, which are both always returning true

@aliarbak
Copy link
Contributor Author

aliarbak commented Oct 5, 2023

Hey @Joachim-Lebrun, I need to rebase from develop, can you allow me to force-push to the transfer-fees-module branch?

@aliarbak aliarbak force-pushed the transfer-fees-module branch from 384fb9b to 4555054 Compare October 6, 2023 11:46
@Joachim-Lebrun Joachim-Lebrun merged commit f881aa1 into develop Oct 6, 2023
3 checks passed
@Joachim-Lebrun Joachim-Lebrun deleted the transfer-fees-module branch October 6, 2023 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants