-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(TFM) Add transfer fees module #168
Conversation
let's merge #169 first on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- add the
isPlugAndPlay
andcanComplianceBind
after Add plug & play functions to compliance modules #169 is merged to develop - remove useless checks to save gas
- modify
setFee
function to be called by the Modular Compliance contract
just need to still add the |
Hey @Joachim-Lebrun, I need to rebase from develop, can you allow me to force-push to the transfer-fees-module branch? |
384fb9b
to
4555054
Compare
Notes:
canComplianceBind
function is for the plug-and-play support discussed before. It checks whether the module is a token agent (and is required for the module to function). It should be called from theaddComplianceModule