Move general common code to "core" library #1868
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CendioOssman
force-pushed
the
corelib
branch
2 times, most recently
from
494c375 to
5811d4b
Compare
|
I think it's okay to just move the cross-platform part and keep the structure of the other RFBs. |
CendioOssman
force-pushed
the
corelib
branch
5 times, most recently
from
f8e901f to
b8953f9
Compare
KangLin
reviewed
Nov 22, 2024
KangLin
reviewed
Nov 22, 2024
KangLin
reviewed
Nov 22, 2024
CendioOssman
force-pushed
the
corelib
branch
from
b8953f9 to
c3bf03d
Compare
|
The latest shuffling caused the commit "Move configuration to core library" to fail to build. The problem is the dependency loops, and that commit just got unlucky. We might get lucky shuffling the order around, but we also might not. I don't know if it's worth the extra effort or if we can live with one broken commit. |
CendioOssman
force-pushed
the
corelib
branch
from
c3bf03d to
e56b175
Compare
This inline class just makes this header overly complex.
Make compile times faster by reducing the number of headers included in other headers.
libtool seems to have some issues ordering everything correctly, and this seems to work better.
This is a network function, so it makes more sense in the network library.
Try to keep the code more compact for the simple things where the type should be obvious from the context. Helps us avoid line wrapping. Also remove explicit conversions to Region where the compiler is able to figure it out by itself, again to reduce line length.
We normally avoid specifying a class' own namespace prefix in order to keep the code more compact. Region was the sole exception.
Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
Avoid surprises by specifying the number of entries in the array, rather than the total size of the array.
Make this code a bit more readable by getting rid of some of the repeated casts.
Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
Make it clearer what is protocol handling and what is just general plumbing. This is one step of several.
Let's clear things up by categorizing our utility functions.
These functions assumes there is a specific ordering between the given moments. Make sure we don't return something completely crazy if this ordering isn't true.
They weren't that well used, and were mostly just confusing special functions anyway. Allows us to move away from generic and ambigious headers such as "util".
It's just string helper functions here, so let's get rid of the catch-all name for this module.
These are general plumbing, so they fit in nicely with the new core library.
OS abstractions are generic enough that we can merge these with the new core library.
OS abstractions are generic enough that we can merge these with the new core library.
We should hopefully no longer require the common libraries to be linked twice anymore for things to work.
To reduce the risk of duplicating the libraries on the link line, as we have absolute paths in the .la files.
There were not many uses of this left after the move to std::exception and the move to the core library. Let's get rid of the last stragglers and reduce the risk of name collisions.
CendioOssman
force-pushed
the
corelib
branch
from
b3ee768 to
a7a4d68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
common/structure has been a bit messy in some cases because some general infrastructure was located incommon/rfb. Besides the confusion about the purpose of each library, it also created dependency loops, creating issues such as #1691.Solve this by moving generic support code to a new library called "core" that serves as a base for everything else.
I've tried to perform this move in a way that minimises the diffs, and hence damage to
git blame.