Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize on sentence case #1865

Merged
merged 3 commits into from
Nov 22, 2024
Merged

Conversation

madnicendio
Copy link
Contributor

Add fixes to both titles as well as for log messages, exceptions and errors.

Copy link
Member

@CendioOssman CendioOssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly good. Nice work!

But I am lacking a rationale. Standardising on sentence case is fine by me, but it's good to have something for future questions.

Ideally something in the commit message(s), but at least here in the PR if it's too large.

LICENCE.TXT Outdated Show resolved Hide resolved
common/rfb/Congestion.cxx Outdated Show resolved Hide resolved
unix/x0vncserver/XDesktop.cxx Outdated Show resolved Hide resolved
common/rdr/RandomStream.cxx Outdated Show resolved Hide resolved
vncviewer/Viewport.cxx Outdated Show resolved Hide resolved
win/rfb_win32/CleanDesktop.cxx Outdated Show resolved Hide resolved
win/rfb_win32/CleanDesktop.cxx Outdated Show resolved Hide resolved
The reason for this is to keep a consistency through out the project.
The reason for this is to keep a consistency through out the project.
The reason for this is to keep a consistency through out the project.
@CendioOssman CendioOssman merged commit 9366d8e into TigerVNC:master Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants