Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for package builds #1767

Merged
merged 2 commits into from
Jun 19, 2024
Merged

Updates for package builds #1767

merged 2 commits into from
Jun 19, 2024

Conversation

bphinz
Copy link
Member

@bphinz bphinz commented Jun 19, 2024

No description provided.

@bphinz bphinz requested a review from CendioOssman June 19, 2024 00:10
Copy link
Member

@CendioOssman CendioOssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Just squash the commits and it should be good to merge.

I made some notes of general improvements we might consider for all Debian packages.

contrib/packages/deb/ubuntu-noble/debian/control Outdated Show resolved Hide resolved
Copy link
Member

@CendioOssman CendioOssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something went wrong here. The merge should not be in to this branch.

@CendioOssman
Copy link
Member

I would suggest resolving it manually on the command line as part of merging to master. Or rebase your original commit after bionic was removed.

@bphinz bphinz changed the title Initial build support for Ubuntu 24.04 Updates for package builds Jun 19, 2024
@bphinz bphinz merged commit 4812f13 into TigerVNC:master Jun 19, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants