Add option to run vncsession without forking and detaching #1651
Conversation
|
The updated PR rebases the unmodified, original PR onto the current tip of the master branch. |
|
After digesting everything said here and at #1649 which is the issue this PR resolves, I think the goal of this PR should be to add the -D option to vncsession for runit compatibility. So far, I have tested that it is effective on Void Linux which uses runit as the default init system. I plan to verify it is also effective with Debian's implementation of runit, which has two flavors - runit as the init system replacing systemd, and runit as the process supervisor with either systemd or sysv for the init system. This will take a little while for me to do, and when tests with runit on Debian are complete I will update the PR if this seems to be a useful addition applicable to more than just Void Linux. If this is only needed for Void Linux, I will just close the PR as something I do not plan to pursue further since the maintenance burden probably outweighs the benefit of this PR in that case. |
zmudc
force-pushed
the
master
branch
3 times, most recently
from
3b2670b to
fda020b
Compare
Option is -D, which is what sshd uses for the same option. Also add description of the new option to the vncsession man page. Tested on Void Linux using the new option, also tested on Fedora without using the new option. Resolves TigerVNC#1649
Option is -D, which is what sshd uses for the same option.
Also added description of the new option to the vncsession man page.
Tested on top of up-to-date version 1.13.80,
commit 094496e (Merge pull request #1648 from TigerVNC/copyright) on Void Linux with runit system service manager.
Also tested on top of Fedora 38 with version 1.13.1 and systemd with Type=exec service and -D option passed to vncsession in vncsession-start.
Resolves #1649