Skip to content

Commit

Permalink
rename maximize param
Browse files Browse the repository at this point in the history
[ 72%] Building CXX object vncviewer/CMakeFiles/vncviewer.dir/DesktopWindow.cxx.o
/Users/fedo/repos/tigervnc/vncviewer/DesktopWindow.cxx:177:7: error: reference to non-static member function must be called; did you mean to call it with no arguments?
  177 |   if (maximize) {
      |       ^~~~~~~~
      |               ()
/Users/fedo/repos/tigervnc/vncviewer/DesktopWindow.cxx:177:7: error: value of type 'void' is not contextually convertible to 'bool'
  177 |   if (maximize) {
      |       ^~~~~~~~
2 errors generated.
make[2]: *** [vncviewer/CMakeFiles/vncviewer.dir/DesktopWindow.cxx.o] Error 1
make[1]: *** [vncviewer/CMakeFiles/vncviewer.dir/all] Error 2
make: *** [all] Error 2
  • Loading branch information
phedoreanu committed Dec 16, 2024
1 parent 24a8909 commit e66cfc7
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions vncviewer/DesktopWindow.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -172,9 +172,9 @@ DesktopWindow::DesktopWindow(int w, int h, const char *name,
}

#ifdef __APPLE__
// On OS X we can do the maximize thing properly before the
// window is showned. Other platforms handled further down...
if (maximize) {
// On OS X we can do the maximizeParam thing properly before the
// window is shown. Other platforms handled further down...
if (maximizeWindow) {
int dummy;
Fl::screen_work_area(dummy, dummy, w, h, geom_x, geom_y);
}
Expand Down Expand Up @@ -208,7 +208,7 @@ DesktopWindow::DesktopWindow(int w, int h, const char *name,
// maximized property on Windows and X11 before showing the window.
// See STR #2083 and STR #2178
#ifndef __APPLE__
if (maximize) {
if (maximizeParam) {
maximizeWindow();
}
#endif
Expand Down
2 changes: 1 addition & 1 deletion vncviewer/parameters.cxx
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ IntParameter qualityLevel("QualityLevel",
"JPEG quality level. 0 = Low, 9 = High",
8);

BoolParameter maximize("Maximize", "Maximize viewer window", false);
BoolParameter maximizeParam("Maximize", "Maximize viewer window", false);
BoolParameter fullScreen("FullScreen", "Enable full screen", false);
StringParameter fullScreenMode("FullScreenMode", "Specify which monitors to use when in full screen. "
"Should be either Current, Selected or All",
Expand Down
2 changes: 1 addition & 1 deletion vncviewer/parameters.h
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ extern rfb::IntParameter compressLevel;
extern rfb::BoolParameter noJpeg;
extern rfb::IntParameter qualityLevel;

extern rfb::BoolParameter maximize;
extern rfb::BoolParameter maximizeParam;
extern rfb::BoolParameter fullScreen;
extern rfb::StringParameter fullScreenMode;
extern rfb::BoolParameter fullScreenAllMonitors; // deprecated
Expand Down

0 comments on commit e66cfc7

Please sign in to comment.