Add first version of strong name signature signer #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| Console.WriteLine(); | ||
| } | ||
|
|
|
CI build is failing because it can't find System.Collections.Immutable which is on myget.org. I'm not sure how to change packages setting. Will work on that later. |
krwq
force-pushed
the
strongNameSignatureSigner
branch
4 times, most recently
from
ca59fb1 to
eb23cea
Compare
|
|
||
| response | ||
| .Should().HaveCount(256, "Because that is the length of an RSA256 signed digest"); | ||
| using (FileStream outputPeImage = new FileStream(signedPath, FileMode.Create, FileAccess.ReadWrite)) |
There was a problem hiding this comment.
Since the comparison dll's are static, can we just include them as resources? It would allow us to get rid of a bunch of this code related to opening files and would eliminate a bunch of potential issues associated with file paths/copies in various test environments.
krwq
force-pushed
the
strongNameSignatureSigner
branch
3 times, most recently
from
8c97556 to
808806c
Compare
krwq
force-pushed
the
strongNameSignatureSigner
branch
from
808806c to
faff5d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.