Add migration to remove obsolete settings (facets_enabled_collection … #2204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jonathangreen
requested changes
Dec 9, 2024
Comment on lines
20
to
23
| conn.execute( | ||
| "UPDATE integration_library_configurations set settings = settings::jsonb - 'facets_enabled_collection'" | ||
| ) | ||
| conn.execute( | ||
| "UPDATE integration_library_configurations set settings = settings::jsonb - 'facets_default_collection'" | ||
| ) |
There was a problem hiding this comment.
These settings are stored in the libraries table, not the integration_library_configurations table.
Minor: You can also do the update in a single update statement and without using a cast to jsonb since the column already has that datatype.
Suggested change
| conn.execute( | |
| "UPDATE integration_library_configurations set settings = settings::jsonb - 'facets_enabled_collection'" | |
| ) | |
| conn.execute( | |
| "UPDATE integration_library_configurations set settings = settings::jsonb - 'facets_default_collection'" | |
| ) | |
| conn.execute( | |
| "UPDATE libraries set settings_dict = " | |
| "settings_dict - array['facets_enabled_collection', 'facets_default_collection']" | |
| ) |
|
@jonathangreen : I'll upgrade the migration target once I've merged in the new events PR which also has a migration. |
dbernstein
force-pushed
the
migration-to-remove-collection-facet-settings-from-db
branch
from
b446928 to
8de86bc
Compare
dbernstein
force-pushed
the
migration-to-remove-collection-facet-settings-from-db
branch
from
8de86bc to
336ec92
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2204 +/- ##
=======================================
Coverage 91.09% 91.09%
=======================================
Files 363 363
Lines 41201 41201
Branches 8827 8827
=======================================
Hits 37531 37531
Misses 2406 2406
Partials 1264 1264 ☔ View full report in Codecov by Sentry. |
dbernstein
deleted the
migration-to-remove-collection-facet-settings-from-db
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and facets_default_collection).
Description
This is a follow-up PR to clean-up obsolete settings removed in #2182
Motivation and Context
How Has This Been Tested?
Checklist