Fix AttributeError causing Loan Notification script to fail (PP-997) #1698
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make sure we are catching possible
AttributeError
exceptions and logging them, then continuing with other notifications.Motivation and Context
It looks like the Loans Notification script is failing for some of our production CM instances with:
This is causing us not write the already send notifications out to the DB, which means we try to send them again ... and again .. and again.
How Has This Been Tested?
Running unit tests.
Checklist