Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the externalintegrationslinks table #1379

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

jonathangreen
Copy link
Member

Description

This PR removes the now unused externalintegrationslinks table.

Motivation and Context

As of #1377 the externalintegrationslinks table is no longer being used. It is kept around in that PR in case we need to roll back those changes. Once those changes are successfully running everywhere, we should merge this PR to remove the unused table.

How Has This Been Tested?

  • Running tests in CI

Checklist

  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@jonathangreen jonathangreen added the DB migration This PR contains a DB migration label Sep 13, 2023
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (5484028) 90.29% compared to head (07834a2) 90.35%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1379      +/-   ##
==========================================
+ Coverage   90.29%   90.35%   +0.06%     
==========================================
  Files         232      232              
  Lines       29751    29699      -52     
  Branches     6797     6786      -11     
==========================================
- Hits        26864    26835      -29     
+ Misses       1843     1823      -20     
+ Partials     1044     1041       -3     
Files Coverage Δ
core/model/collection.py 95.95% <ø> (+0.81%) ⬆️
core/model/configuration.py 92.33% <ø> (-0.08%) ⬇️
api/admin/controller/settings.py 79.87% <33.33%> (+4.14%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathangreen jonathangreen force-pushed the feature/storage-integration branch from 8e4990d to d739045 Compare September 15, 2023 12:50
@jonathangreen jonathangreen force-pushed the feature/remove-integration-links branch from b874bdf to cf60c47 Compare September 15, 2023 12:55
@jonathangreen jonathangreen force-pushed the feature/storage-integration branch from d739045 to 3d690c5 Compare September 19, 2023 12:44
@jonathangreen jonathangreen force-pushed the feature/remove-integration-links branch from cf60c47 to 0696d92 Compare September 19, 2023 12:50
@jonathangreen jonathangreen force-pushed the feature/storage-integration branch 2 times, most recently from 7371a07 to 42586d2 Compare September 22, 2023 15:38
Base automatically changed from feature/storage-integration to main September 22, 2023 19:02
@jonathangreen jonathangreen force-pushed the feature/remove-integration-links branch from 0696d92 to 1563020 Compare September 22, 2023 19:05
@jonathangreen jonathangreen requested a review from a team October 5, 2023 20:10
@jonathangreen
Copy link
Member Author

Now that v10.0.0 is out, I think we are good to merge this.

Copy link
Contributor

@RishiDiwanTT RishiDiwanTT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jonathangreen jonathangreen merged commit aba61b7 into main Oct 6, 2023
29 of 30 checks passed
@jonathangreen jonathangreen deleted the feature/remove-integration-links branch October 6, 2023 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DB migration This PR contains a DB migration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants