-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-add vehicles again #247
Merged
Capital-Asterisk
merged 10 commits into
TheOpenSpaceProgram:master
from
Capital-Asterisk:readd-vehicles-again
Oct 31, 2023
Merged
Re-add vehicles again #247
Capital-Asterisk
merged 10 commits into
TheOpenSpaceProgram:master
from
Capital-Asterisk:readd-vehicles-again
Oct 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Well that's an enormous diff. I reviewed it as best i could and didn't see anything glaring. But no promises that i didn't overlook something. |
if you rebase on master, everything in the CI should work except for the windows analyzer. |
Ok now CI is 100% green. |
You can see the code scanning results here: https://github.com/TheOpenSpaceProgram/osp-magnum/security/code-scanning |
Thanks for the CI fixes! |
Capital-Asterisk
merged commit Oct 31, 2023
a65640f
into
TheOpenSpaceProgram:master
16 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This 100% finishes the pipeline rewrite and fixes everything commented-out in #244
DrawTransformObservers
from drawing_fn.h:
Other notes
One may notice that in many places I'm dropping the
m_
naming convention for structs that don't have (or have very few) member functions. Them_
is useful for member functions as C++'s implicitthis->
can make it difficult to tell which variables are or aren't member variables. If there are no member functions, then they're redundant and contribute to making my eyes bleed as I try to understand what the code is doing, so they should be removed.