Check user excludes sanity #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
August 4, 2019 12:38
added /var/db/repos/gentoo and /var/cache/distfiles to hard-coded list of excludes. Portage has moved (when?) according to https://wiki.gentoo.org/wiki//usr/portage
Added portageq logic to detect where portage stores its tree and distfiles. If this fails, fall back to a default list declared in EXCLUDES_DEFAULT_PORTAGE
Portage has moved
add new portage paths with optional portageq logic (#18)
user-excludes are checked for their existance and in case they do not exist (typo) a warning message is displayed.
|
@drwulsen Could you please rebase this into one commit? |
lucianposton
reviewed
Feb 4, 2020
| @@ -65,7 +66,12 @@ while getopts ':t:e:skqcblph' flag; do | |||
| EXCLUDE_LOST=1 | |||
| ;; | |||
| e) | |||
| USER_EXCL+=" --exclude=${OPTARG}" | |||
| if [ -e ${OPTARG} ] | |||
There was a problem hiding this comment.
OPTARG is likely to contain * since --exclude accepts such values in order to glob.
Also the arg to --exclude is relative to TARGET. This will be an issue when TARGET isn't / nor $(pwd).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The user excludes list generated by adding -e /foo/ to the parameters can have typos made by the user.
This commit will display a warning on what was not found (even in quiet mode) and ask the user to confirm this is intended.