Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pre-build commands. #584

Open
wants to merge 1 commit into
base: scripting
Choose a base branch
from

Conversation

tadashuai
Copy link

Describe the issue (if no issue has been made)

  1. Everytime after updating C# scripts, we need to build its solution manually, like Ctrl + B.
    Now just build Hazal.sln or HIT F5 directly!
  2. Also see [Suggestion] Set the root namespace of Hazel-ScriptCore to "Hazel" #582 .

PR impact (Make sure to add closing keywords)

List of related issues/PRs this will solve:

Impact Issue/PR
Issues this solves #582
Other PRs this solves None

Proposed fix (Make sure you've read on how to contribute to Hazel)

  1. Will build C# projects first when building Hazel C++ projects. Added the pre-build commands in the Hazel premake file.
    By the way, it checks whether the sandbox solution exists and notifies.
  2. Only set C# project root namespace. <= Added namespace line in the C# premake files.

&1. Will build C# projects before Hazel C++ projects.
&2. Set C# project root namespace.
@tadashuai
Copy link
Author

But if we only changed the C# code, it means the Hazel project doesn't need to be rebuilt and no pre-build commands are executed. At this point we still need to manually build the C# project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant