DRT: fix distributed routing and cleanup code #6284
Conversation
Signed-off-by: osamahammad21 <[email protected]>
…anup Signed-off-by: osamahammad21 <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: osamahammad21 <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: osamahammad21 <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
Signed-off-by: osamahammad21 <[email protected]>
|
clang-tidy review says "All clean, LGTM! 👍" |
src/drt/doc/Distributed.md
Outdated
| The main steps on the NFS server machine are: | ||
|
|
||
| 1. run ` sudo apt install nfs-kernel-server ` and ` sudo apt install nfs-common ` | ||
| 1. In the etc/exports file, add the following line replacing \${PATH} with the actual shared directory path you choose: ` ${PATH} 10.128.0.0/255.255.0.0(rw,no_subtree_check,no_root_squash) ` |
There was a problem hiding this comment.
Is 10.128.0.0 generic for all users?
There was a problem hiding this comment.
not really. it depends on the private network local ip range.
There was a problem hiding this comment.
Then the docs should explain that the users needs to update this as well as PATH.
| @@ -35,12 +35,13 @@ spec: | |||
| hostNetwork: true | |||
| containers: | |||
| - name: openroad | |||
| image: openroad/centos-binary:latest | |||
| image: openroad/orfs:v3.0-1871-g4e29c449 | |||
There was a problem hiding this comment.
no idea. but it's the most recent since latest tag is not updated.
There was a problem hiding this comment.
@vvbandeira @sombraSoft what do you recommend here for the tag?
There was a problem hiding this comment.
The image will exist for as long as DockerHub maintains the current policy of allowing unlimited images for open-source projects.
One case would be to use the base ORFS image and compile OR on the fly to guarantee that the code being tested is the current checkout code. The other case might be to use orfs:latest and include this in the CI for ORFS and OR to ensure it will always work.
There was a problem hiding this comment.
@vvbandeira orfs:latest does not appear to be updating as Osama commented. See https://hub.docker.com/r/openroad/orfs/tags?name=latest
Signed-off-by: osamahammad21 <[email protected]>
|
@maliberty re-review please. |
|
clang-tidy review says "All clean, LGTM! 👍" |
No description provided.