Allow UIView subviews to be a part of Accessibility Tree

[patryk-sredzinski]

If you add views to node.view, then those views aren't visible by AccessibilityInspector. This PR allows that

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ patryk-sredzinski
❌ Patryk Średziński

---

Patryk Średziński seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[rcancro]

This is a long complicated method. It is quite possible that in the future someone will add to it, likely at the end of the method. This early return could cause newly added logic to be skipped. To protect against that, I'd prefer you put your logic inside of an if and not early return:

if (!modalSubnode) {
   // your logic
    ....
}

[rcancro]

This is cheaper than iterating over elements and should be done first.

[rcancro]

We are looping over subviews and elements for each subview. It would be more efficient to put the elements in a set so lookup is O(1), or use a smart diff algorithm to get only the subviews not in elements and iterate over those.

[elements containsObject:subview] is likely the most expensive operation in this loop, so it should at the very least be moved to the last possible check. e.g.,

if ((subview.isAccessibilityElement || subview.accessibilityElementCount > 0)) && ! [elements containsObject:subview]) {
      [elements addObject:subview];
}