Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor fix suggestions #29

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Minor fix suggestions #29

wants to merge 4 commits into from

Conversation

Eerosal
Copy link
Collaborator

@Eerosal Eerosal commented Jul 18, 2024

Timetable performance

  • Enable memory+disk level caching for thumbnails
  • Add memoization to the critical parts
  • Use VirtualizedList to reduce rendered elements
  • Add a loading transition between days to prevent the app from freezing during rapid page changes
  • Use Zustand to interact with AsyncStorage and cache favorites in-memory

Timetable events

  • Prevent text from flowing under the favorite button by adding margin
  • This update should not change text centering due to the appropriate negative margins

About Webview

  • Change background to match the app background instead of being #FFF

Date selector buttons

  • Move date selector buttons higher in z-index to prevent issues arising when the app is scaled
  • Also makes it possible to add hitSlop to make the buttons easier to use

@Eerosal Eerosal requested a review from Adventune July 18, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant