-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add options for share json support #11
Conversation
{
"version": "8.0.0",
"initSources": [
{
"stratum": "user",
"models": {
"//Example Datasets": {
"type": "group",
"isOpen": true,
"knownContainerUniqueIds": [
"/"
]
},
"__User-Added_Data__": {
"type": "group",
"name": "User-Added Data",
"members": [
{
"type": "csv",
"name": "http://localhost:3001/data/2011Census_TOT_LGA.csv",
"description": "",
"info": [],
"show": true,
"splitDirection": 0,
"url": "http://localhost:3001/data/2011Census_TOT_LGA.csv",
"opacity": 0.8
}
],
"description": "The group for data that was added by the user via the Add Data panel.",
"info": [],
"isOpen": true,
"knownContainerUniqueIds": [
"/"
]
},
"/http://localhost:3001/data/2011Census_TOT_LGA.csv": {
"type": "csv",
"name": "http://localhost:3001/data/2011Census_TOT_LGA.csv",
"show": true,
"splitDirection": 0,
"url": "http://localhost:3001/data/2011Census_TOT_LGA.csv",
"opacity": 0.8,
"knownContainerUniqueIds": [
"__User-Added_Data__"
]
}
},
"stories": [],
"workbench": [
"/http://localhost:3001/data/2011Census_TOT_LGA.csv"
], |
Documenting this as you go is so great @nf-s - get them into an ADR (doesn't need to be perfect, just copy what you have in the PR into the .md) so that it lives in the repo as well. |
WMS support
…nverter into share-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. There's a small number of changes needed.
@@ -1,6 +1,6 @@ | |||
{ | |||
"name": "catalog-converter", | |||
"version": "0.0.2", | |||
"version": "0.0.2-alpha.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Odd version number, to go from 0.0.2 to 0.0.2-alpha. Any reason? There's no good versioning policy for this repo yet so I'll take suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think @soyarsauce did this for terrace stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes. Sorry that I didn't make it clear which mergeRecursive
I was referring to.
Add options to support share json conversion
Mother issue - Model architecture: Share & story migration
For my assumptions - see https://github.com/TerriaJS/catalog-converter/blob/master/architecture/0001-share-conversion-assumptions.md
Main changes
partial
property inConversionOption
- this means that errors aren't thrown for required props (egname
orurl
)convertShare
function withShare
,ShareResult
, andStory
typescatalogMemberProps
{ v7: "isShown", v8: "show" }
splitDirection
TerriaJS-Server changes
See TerriaJS/terriajs-server#119
Missing share properties:
pickedFeatures
- not in v8 share links (create or load)timeline
- v7 timeline is different from v8locationMarker
- not in v8sharedFromExplorerPanel
- not in v8This also contains WMS support (see #13 PR and #12 Issue)