Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WMS item support #12

Open
42 of 80 tasks
nf-s opened this issue Sep 24, 2020 · 3 comments
Open
42 of 80 tasks

WMS item support #12

nf-s opened this issue Sep 24, 2020 · 3 comments

Comments

@nf-s
Copy link
Contributor

nf-s commented Sep 24, 2020

WMS

Done

CatalogMember

Copied

  • description
  • info
  • { v7: "isShown", v8: "show" }
  • splitDirection

Ignored

  • name
  • type
  • isEnabled
  • parents

WMS

(bold = some transformation)

Copied

  • url
  • layers
  • opacity
  • linkedWcsUrl
  • linkedWcsCoverage
  • chartColor
  • featureTimesProperty
  • chartType
  • featureInfoTemplate

Removed

...

TODO

Bold = requires transformation
If no transformation is required, you should be able to copy the property over as is (with same property key)

+ = serialized in v7

Catalog member (Catalog member or catalog Item)

  • infoSectionOrder
  • shortReportSections
  • shortReport
  • legendUrl
  • legendUrls
  • chartDisclaimer (add support in catalog converter)
  • rectangle +
  • isLegendVisible +
  • currentTime
  • dateFormat
  • disablePreview
  • isUserSupplied Not required as far as I can tell
  • cacheDuration
  • forceProxy
  • id
  • hideSource
  • isLoading

ImageryLayer

  • keepOnTop +
  • initialTimeSource +

WMS

  • dataCustodian (this exists in DataCustodianTraits)
  • leafletUpdateInterval (Add leafletUpdateInterval trait for wms items. #9)
  • styles
  • dimensions (may need transformation depending if _dim is included in name - in v8 we drop _dim)
  • availableStyles
  • availableDimensions
  • getCapabilitiesUrl
  • parameters
  • isGeoServer
  • minScaleDenominator
  • hideLayerAfterMinScaleDenominator
  • maxRefreshIntervals
  • supportsDeltaComparison - Not sure how to handle this... v7 doesn't have any of the other DiffableTraits

Not in V8 (may need to be ported)

CatalogMember

  • isPromoted
  • isHidden
  • initialMessage
  • customProperties
  • shareKeys
  • isWaitingForDisclaimer

Catalog item

  • nowViewingCatalogItem +
  • creatorCatalogItem
  • nowViewingIndex +
  • zoomOnEnable
  • attribution +
  • metadataUrl
  • dataUr +
  • dataUrlType +
  • displayChoicesBeforeLegend
  • clock
  • isLoading
  • isEnableable
  • isMappable
  • showsInfo
  • nowViewingMessage
  • maximumShownFeatureInfos
  • useOwnClock +
  • featureInfoTemplate.formats (Port Formats for feature info terriajs#4829)

ImageryLayer

WMS

@rowanwins
Copy link
Contributor

rowanwins commented Sep 24, 2020

supportsColorScaleRange, colorScaleMinimum, colorScaleMaximum and isNcWMS are included in TerriaJS/terriajs#4724

@nf-s
Copy link
Contributor Author

nf-s commented Sep 25, 2020

Questions

initialTimeSource

V7

/**
   * Options for the value of the animation timeline at start. Valid options in config file are:
   *     initialTimeSource: "present"                            // closest to today's date
   *     initialTimeSource: "start"                              // start of time range of animation
   *     initialTimeSource: "end"                                // end of time range of animation
   *     initialTimeSource: An ISO8601 date e.g. "2015-08-08"    // specified date or nearest if date is outside range
   * @type {String}
   */

V8

"The initial time to use if `Current Time` is not specified. Valid values are:\n\n" +
      "  * `start` - the dataset's start time\n" +
      "  * `stop` - the dataset's stop time\n" +
      "  * `now` - the current system time. If the system time is after `Stop Time`, `Stop Time` is used. If the system time is before `Start Time`, `Start Time` is used.\n\n" +
      "  * `none` - do not automatically set an initial time\n" +
      "This value is ignored if `Current Time` is specified",

What I have done

Map the following:

  • present -> now
  • start -> start
  • stop -> end

If not one of the previous options, v8.currentTIme = v7.initialTimeSource

@irbian
Copy link

irbian commented May 29, 2024

Opacity needs to be transformed from string to float

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants