-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weather app – Helene Westrin #421
Open
HeleneWestrin
wants to merge
17
commits into
Technigo:master
Choose a base branch
from
HeleneWestrin:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HeleneWestrin
changed the title
Weatherington – a weather app
Weather app – Helene Westrin
Sep 29, 2024
JennieDalgren
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've done a fantastic job with the weather app! 🎉
HTML/CSS
- Good job with the structure and nice little favicon too.
- Great use of css variables!
JavaScript
- Nice job with the fetching from the API as well as using some mock data. Clever!
- Nice to see some error handling/empty state ⭐
- Love the way you have used helper functions.
Clean Code
- Your JavaScript is well-organized and modular, with helper functions like
formatTemperature
andgetWeekdayAbbreviation
. - The comments you’ve provided are generally helpful, although keeping them concise, sometimes your code is very explanatory itself.
- Don't mix arrow functions with function keyword, be consistent
Changes Requested
No changes are necessary.
Keep up the great work, and I look forward to seeing your next project! 😊
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Netlify link
https://weatherington.netlify.app