Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

W10 | project-survey-vite | Xing Y. & Erika O. #83

Open
wants to merge 39 commits into
base: main
Choose a base branch
from

Conversation

xingyin2024
Copy link

Netlify link

https://survey-personality.netlify.app

Collaborators

Xing Y. & Erika O.

Copy link

@JennieDalgren JennieDalgren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with this project!

Clean up some un useful console logs and fix the indentation in you css files.
Also take a look at the accessibility score on Lighthouse. The required number is at least 95. You got 89. I think it mainly has to do with color contrasts of you grey buttons.

Good job with components and great that you've added comments regarding each components purpose and functionality. It looks like you really focused on understanding the React state and components this week.

Do the small fixes and keep up the good work!

src/App.jsx Outdated Show resolved Hide resolved
src/components/MultiStepForm.jsx Outdated Show resolved Hide resolved
src/components/MultiStepForm.jsx Outdated Show resolved Hide resolved
@JennieDalgren JennieDalgren self-assigned this Oct 24, 2024
@xingyin2024
Copy link
Author

I implemented a validation function for both the 'Next' step and form submission, displaying validation messages in red text below the disabled button instead of using alerts. The button design was updated to a more modern shape, and I added value="" to the first option in the dropdown to ensure the button re-disables if an empty selection is made.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants