refactor: edit parameter

Team-Sopetit · Nov 30, 2024 · 4cec824 · 4cec824
1 parent cd1897f
commit 4cec824
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/src/main/java/com/soptie/server/domain/membermission/MemberMissionService.java b/src/main/java/com/soptie/server/domain/membermission/MemberMissionService.java
@@ -70,7 +70,7 @@ public void achieveMemberMission(long memberId, long missionId) {
 		memberMissionAdapter.update(memberMission);
 		memberMissionAdapter.flush();
 		memberMissionAdapter.delete(memberMission);
-		missionHistoryAdapter.save(memberMission.getId(), memberMission.getMemberId());
+		missionHistoryAdapter.save(memberMission);
 	}
 
 	public Optional<GetMemberMissionResponse> getMemberMission(long memberId) {

diff --git a/src/main/java/com/soptie/server/persistence/adapter/mission/MissionHistoryAdapter.java b/src/main/java/com/soptie/server/persistence/adapter/mission/MissionHistoryAdapter.java
@@ -4,6 +4,7 @@
 
 import org.springframework.stereotype.Component;
 
+import com.soptie.server.domain.membermission.MemberMission;
 import com.soptie.server.persistence.entity.mission.MissionHistoryEntity;
 import com.soptie.server.persistence.repository.mission.MissionHistoryRepository;
 
@@ -14,8 +15,8 @@
 public class MissionHistoryAdapter {
 	private final MissionHistoryRepository historyRepository;
 
-	public void save(long memberMissionId, long memberId) {
-		historyRepository.save(new MissionHistoryEntity(memberMissionId, memberId));
+	public void save(final MemberMission memberMission) {
+		historyRepository.save(new MissionHistoryEntity(memberMission.getMissionId(), memberMission.getMemberId()));
 	}
 
 	public void deleteById(long historyId) {