-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gifticon:Order(FK) -> Order:Gifticon(FK) 로 수정 #195
Draft
vanillacake369
wants to merge
12
commits into
main
Choose a base branch
from
refactor/order-has-gifticon-fk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tearDown() 순서 조정 - (이전) - saveOrder() - saveGifticon() - (이후) - saveGifticon() - saveOrder()
…rDown() 순서 조정 - (이전) - saveOrder() - saveGifticon() - (이후) - saveGifticon() - saveOrder()
- "판매입찰 기프티콘에 주문 저장" 로직 삭제
- (이전) - GifticonMapper 사용 - GifticonQueryService 사용 - GifticonRepositoryCustomImpl 사용 - (이후) - OrderMapper 사용 - OrderQueryService 사용 - OrderRepositoryCutomImpl 사용
…스 수정 - (이전) - 주문 저장 이후 기프티콘 저장 - (이후) - 기프티콘 저장 이후 주문 저장
…ellRepository 에서 Order 추가 로직 제거
Test Results56 tests 46 ✅ 4s ⏱️ Results for commit 5bc1f7b. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
개요
기프티콘 엔티티에서 주문 엔티티 FK (X)
-> 주문 엔티티에서 기프티콘 엔티티 FK (O)
작업사항
관련 이슈