-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added gamemode and platform filtering on all player data endpoint #209
Conversation
Reviewer's Guide by SourceryThis PR adds gamemode and platform filtering capabilities to the player career endpoint. The implementation includes refactoring the player career parser to handle filtered data requests, adding new query parameters to the API endpoint, and improving error handling. The changes also include splitting test files and updating the search functionality to handle player names more effectively. Class diagram for PlayerCareerParser changesclassDiagram
class PlayerCareerParser {
+filter_request_using_query(kwargs)
+_filter_stats(kwargs)
+_filter_all_stats_data(kwargs)
+parse_data()
}
note for PlayerCareerParser "Added _filter_all_stats_data method and updated filter_request_using_query method to handle gamemode and platform filtering."
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @TeKrop - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Quality Gate passedIssues Measures |
Summary by Sourcery
Implement gamemode and platform filtering for player career data endpoint and enhance the player career parser to support these filters. Update tests to cover new filtering functionality and error handling scenarios.
New Features:
Enhancements:
Tests: