Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed an issue with LastUpdatedAt cache refresh #185

Merged
merged 1 commit into from
Aug 27, 2024

Conversation

TeKrop
Copy link
Owner

@TeKrop TeKrop commented Aug 27, 2024

Summary by Sourcery

Fix the cache refresh issue by adding LastUpdatedAtParser to the parser class mapping and updating the cache key generation logic to handle it correctly.

Bug Fixes:

  • Fix an issue with the cache refresh mechanism by correctly handling the LastUpdatedAtParser in the cache key generation logic.

@TeKrop TeKrop added the bug Something isn't working label Aug 27, 2024
@TeKrop TeKrop self-assigned this Aug 27, 2024
Copy link
Contributor

sourcery-ai bot commented Aug 27, 2024

Reviewer's Guide by Sourcery

This pull request addresses an issue with the LastUpdatedAt cache refresh by adding support for the LastUpdatedAtParser in the check_and_update_cache.py file. The changes involve importing the LastUpdatedAtParser, adding it to the parser class mapping, and updating the logic to handle the LastUpdatedAtParser similarly to the NamecardParser.

File-Level Changes

Change Details Files
Added support for LastUpdatedAtParser
  • Imported LastUpdatedAtParser from app.parsers.search_data_parser
  • Added LastUpdatedAtParser to the PARSER_CLASSES_MAPPING dictionary
  • Updated the condition in get_request_parser_class to handle LastUpdatedAtParser similarly to NamecardParser
app/commands/check_and_update_cache.py

Tips
  • Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
  • Continue your discussion with Sourcery by replying directly to review comments.
  • You can change your review settings at any time by accessing your dashboard:
    • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
    • Change the review language;
  • You can always contact us if you have any questions or feedback.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @TeKrop - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟢 Testing: all looks good
  • 🟢 Complexity: all looks good
  • 🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

@TeKrop TeKrop force-pushed the bugfix/last-updated-at-refresh-fix branch from e9afe25 to c909a57 Compare August 27, 2024 06:59
Copy link

@TeKrop TeKrop merged commit 875d506 into main Aug 27, 2024
3 checks passed
@TeKrop TeKrop deleted the bugfix/last-updated-at-refresh-fix branch August 27, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant