Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Migrate to pnpm and modularise Nx tasks #5234

Merged
merged 25 commits into from
Dec 28, 2023
Merged

chore: Migrate to pnpm and modularise Nx tasks #5234

merged 25 commits into from
Dec 28, 2023

Conversation

lachlancollins
Copy link
Member

@lachlancollins lachlancollins commented Dec 27, 2023 •
edited
Loading

Changes:

  • pnpm import to clone existing locked versions
  • Setup pnpm workspaces
  • Remove yarn.lock and lerna
  • Split tsc and vitest into per-package scripts rather than root-level scripts (can be parallelised by Nx)
  • Fix broken react dependency resolution
  • Replace rm -rf (unix-specific) with rimraf

CI testing time:

  • Before: 42s
  • After: 31s

@lachlancollins lachlancollins changed the title chore: Migrate from yarn to pnpm chore: Migrate to pnpm and modularise Nx tasks Dec 27, 2023
@lachlancollins
Copy link
Member Author

@KevinVandy I've made some great progress here! I reckon I'll be able to submit the tsup PR after this.

KevinVandy
KevinVandy approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@KevinVandy KevinVandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried to find anything broken with this, but don't see anything. Thanks for the hard work. We'll see if publishing still works

@KevinVandy KevinVandy merged commit 51a6fd7 into TanStack:main Dec 28, 2023
1 check passed
@lachlancollins lachlancollins deleted the yarn-to-pnpm branch December 28, 2023 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinVandy KevinVandy KevinVandy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lachlancollins @KevinVandy