Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: getParentRow should search all row model rows #5121

Merged
merged 1 commit into from
Oct 7, 2023
Merged

fix: getParentRow should search all row model rows #5121

merged 1 commit into from
Oct 7, 2023

Conversation

KevinVandy
Copy link
Member

@KevinVandy KevinVandy commented Oct 7, 2023

Currently, with certain filtering or pagination features applied, row.getParentRow() and row.getParentRows() has the possibility to throw an error when trying to find rows that exist, just not in the filtered row model.

Passing in true as the second argument to table.getRow() should fix this.

@KevinVandy KevinVandy merged commit f055715 into TanStack:main Oct 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant