Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better alphanumeric sort of bools and floats (fix #5108) #5109

Merged

Conversation

itsmejoeeey
Copy link
Contributor

Full description on the linked issue #5108

Copy link
Member

@KevinVandy KevinVandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense

@KevinVandy KevinVandy merged commit 3f9d382 into TanStack:main Oct 7, 2023
1 check passed
@C-Higgins
Copy link

The numeric check should be something like ^\d+(\.\d+)?$, not parseFloat. The latter will parse anything that starts with a number. parseFloat('1abc') === 1. See #5124

@rameez-khawaja
Copy link

The numeric check should be something like ^\d+(\.\d+)?$, not parseFloat. The latter will parse anything that starts with a number. parseFloat('1abc') === 1. See #5124

To add to this, the numeric strings with spaces such as "111 222 333" will be parsed as just 111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants