Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix: solid-query): Revert breaking build #4733

Merged
merged 1 commit into from
Jan 1, 2023
Merged

(fix: solid-query): Revert breaking build #4733

merged 1 commit into from
Jan 1, 2023

Conversation

ardeora
Copy link
Contributor

@ardeora ardeora commented Jan 1, 2023

Apologies for going back and forth on this so often.

This is in reference to the breaking build in solid-query. Because client Context value is never passed into the provider

This is potentially an upstream issue #4673

For now, this should be reverted as it's causing dependent packages to break unfortunately too

OrJDev/solid-trpc#8

This is in reference to the breaking build in solid-query.
Because client Context value is never passed into the provider
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jan 1, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 64acdef:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

@codecov-commenter
Copy link

Codecov Report

Base: 96.36% // Head: 92.34% // Decreases project coverage by -4.01% ⚠️

Coverage data is based on head (64acdef) compared to base (eab6e2c).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4733      +/-   ##
==========================================
- Coverage   96.36%   92.34%   -4.02%     
==========================================
  Files          45       89      +44     
  Lines        2281     3751    +1470     
  Branches      640      985     +345     
==========================================
+ Hits         2198     3464    +1266     
- Misses         80      271     +191     
- Partials        3       16      +13     
Impacted Files Coverage Δ
src/core/queryObserver.ts
src/devtools/theme.tsx
src/react/useBaseQuery.ts
src/core/mutation.ts
src/core/query.ts
src/react/logger.native.ts
src/react/useQuery.ts
src/core/infiniteQueryObserver.ts
src/core/hydration.ts
src/react/useQueries.ts
... and 124 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ardeora ardeora requested review from DamianOsipiuk and TkDodo and removed request for DamianOsipiuk January 1, 2023 12:58
@TkDodo TkDodo merged commit 17afa9b into TanStack:main Jan 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants