-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] allow empty groupValue and fallback to empty string as a group #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Increases the RAMFS size to 2.5 GB.
Replaces undefined LOCAL_VOLUME_NAME with LOCAL_SOLR_VOLUME_NAME in ci.yml
Adjusts SearchResultSetServiceTest to be compatible with EXT:solr versions >= 11.5.1.
dkd-friedrich
approved these changes
Feb 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for fixing
dkd-friedrich
added a commit
to dkd-friedrich/ext-solrfluidgrouping-public
that referenced
this pull request
Feb 26, 2024
This is a maintenance release for TYPO3 11.5 LTS, containing: - [BUGFIX] cast maxScore to float by @achimfritz in TYPO3-Solr#33 - [TASK] Increase RAMFS size by @dkd-friedrich - [BUGFIX] Fix environment variable in GitHub workflow by @dkd-friedrich - [BUGFIX] Adjust unit tests for EXT:solr 11.5.1+ by @dkd-friedrich - [BUGFIX] allow empty groupValue and fallback to empty string as a group by @lukasniestroj in TYPO3-Solr#31 Note: solrfluidgrouping is part of solr 12+, so there will be no release for TYPO3 12. Please read the release notes: https://github.com/TYPO3-Solr/ext-solrfluidgrouping/releases/tag/11.0.1 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: * Submit bug reports and feature requests on GitHub * Ask or help or answer questions in our Slack channel * Provide patches through pull requests or review and comment on existing pull requests * Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
Merged
dkd-friedrich
added a commit
to dkd-friedrich/ext-solrfluidgrouping-public
that referenced
this pull request
Feb 26, 2024
This is a maintenance release for TYPO3 11.5 LTS, containing: - [BUGFIX] cast maxScore to float by @achimfritz in TYPO3-Solr#33 - [TASK] Increase RAMFS size by @dkd-friedrich - [BUGFIX] Fix environment variable in GitHub workflow by @dkd-friedrich - [BUGFIX] Adjust unit tests for EXT:solr 11.5.1+ by @dkd-friedrich - [BUGFIX] allow empty groupValue and fallback to empty string as a group by @lukasniestroj in TYPO3-Solr#31 Note: solrfluidgrouping is part of solr 12+, so there will be no release for TYPO3 12. Please read the release notes: https://github.com/TYPO3-Solr/ext-solrfluidgrouping/releases/tag/11.0.1 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: * Submit bug reports and feature requests on GitHub * Ask or help or answer questions in our Slack channel * Provide patches through pull requests or review and comment on existing pull requests * Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
dkd-friedrich
added a commit
that referenced
this pull request
Feb 26, 2024
This is a maintenance release for TYPO3 11.5 LTS, containing: - [BUGFIX] cast maxScore to float by @achimfritz in #33 - [TASK] Increase RAMFS size by @dkd-friedrich - [BUGFIX] Fix environment variable in GitHub workflow by @dkd-friedrich - [BUGFIX] Adjust unit tests for EXT:solr 11.5.1+ by @dkd-friedrich - [BUGFIX] allow empty groupValue and fallback to empty string as a group by @lukasniestroj in #31 Note: solrfluidgrouping is part of solr 12+, so there will be no release for TYPO3 12. Please read the release notes: https://github.com/TYPO3-Solr/ext-solrfluidgrouping/releases/tag/11.0.1 --- How to Get Involved There are many ways to get involved with Apache Solr for TYPO3: * Submit bug reports and feature requests on GitHub * Ask or help or answer questions in our Slack channel * Provide patches through pull requests or review and comment on existing pull requests * Go to www.typo3-solr.com or call dkd to sponsor the ongoing development of Apache Solr for TYPO3 Support us by becoming an EB partner: https://shop.dkd.de/Produkte/Apache-Solr-fuer-TYPO3/ or call: +49 (0)69 - 2475218 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.