[TASK] Evaluate all entries in Services.yaml regarding to shared setting
#4251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tting All entries in Services.yaml become the `shared` setting dependent on its implementation and context. All non-Singleton-Like classes are set to `shared: false` which could stuck with objects states: * on Builder-Objects * on Query-Objects * on other object, those state change is not global relevant Some classes were commented with todos. Relates: TYPO3-Solr#3995 Fixes: TYPO3-Solr#4183, TYPO3-Solr#4246
dkd-kaehm
added a commit
to dkd-kaehm/ext-solr
that referenced
this pull request
Dec 11, 2024
…tting All entries in Services.yaml become the `shared` setting dependent on its implementation and context. All non-Singleton-Like classes are set to `shared: false` which could stuck with objects states: * on Builder-Objects * on Query-Objects * on other object, those state change is not global relevant Relates: TYPO3-Solr#3995 Fixes: TYPO3-Solr#4183, TYPO3-Solr#4246 Ports: TYPO3-Solr#4251
dkd-kaehm
added a commit
that referenced
this pull request
Dec 11, 2024
…tting All entries in Services.yaml become the `shared` setting dependent on its implementation and context. All non-Singleton-Like classes are set to `shared: false` which could stuck with objects states: * on Builder-Objects * on Query-Objects * on other object, those state change is not global relevant Relates: #3995 Fixes: #4183, #4246 Ports: #4251
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All entries in Services.yaml become the
sharedsetting dependent on its implementation and context.All non-Singleton-Like classes are set to
shared: falsewhich could stuck with objects states:Some classes were commented and notated with todos.
Relates: #3995
Fixes: #4183, #4246
Todo:
@todo comments)