Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] Correct typo in searchResultClassName configuration key #4226

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[BUGFIX] Correct typo in searchResultClassName configuration key #4226

wants to merge 1 commit into from

Conversation

beardcoder
Copy link
Contributor

@beardcoder beardcoder commented Nov 21, 2024 •
edited
Loading

Resolves: #4225

dkd-kaehm
dkd-kaehm requested changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@dkd-kaehm dkd-kaehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please search and replace all occurrences of that string:
E.g.:

ext-solr/ext_localconf.php

Lines 146 to 148 in 0c0f2b9

if (!isset($GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultClassName '])) {
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['searchResultClassName '] = SearchResult::class;
}

@dkd-kaehm
Copy link
Collaborator

@beardcoder
Thanks for fixing that issue. Please prepend the title of commit with !!!
also !!![BUGFIX] Correct typo in searchResultClassName configuration key #4226 , to mark it as breaking change.

@dkd-kaehm dkd-kaehm marked this pull request as draft December 12, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkd-kaehm dkd-kaehm dkd-kaehm requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG]: Fix Typo in searchResultClassName Configuration Key
2 participants
@beardcoder @dkd-kaehm